Switch from symbol to intern as the former seems dormant
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses4ever
force-pushed
the
leave-symbol
branch
2 times, most recently
from
017d74d
to
1b8d55c
Compare
ckoparkar
approved these changes
Jun 17, 2024
|
Sounds good to me -- it's all a wannabe reconstruction of Scheme style symbols. Dang, the Github PR review tool feels like it's really caught up with the Phabricator tool we use internally. Pretty nice. |
rrnewton
approved these changes
Jun 18, 2024
|
Thanks, will merge then! The only remaining issue is the absence of the |
`intern` seems to serve the same purpose but is actively maintained by Ryan G. Scott and a part of kmettoverse this hopefully unlocks support for GHC 9.10
ulysses4ever
force-pushed
the
leave-symbol
branch
from
42afa46
to
fad6a23
Compare
|
All right, I ensured that the Show and Read instances work the same as before. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internseems to serve the same purpose assymbolbut, unlike it, is actively maintained by Ryan G. Scott and is a part of kmettoverse.The only kink is that it doesn't have a Read instance. I'm not sure why we need a Read instance anyway, but I had to define a trivial one otherwise it's a hassle to remove all
deriving Readover the code. It'd be great to figure out if we really need it.This hopefully unlocks support for GHC 9.10 (currently,
symbolprecludes it).